feat(tool/charts): add repo cmd #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tk tool charts add-repo for adding a repository using the CLI
There was a problem hiding this comment.
Neither the add nor the addRepo cmds are idempotent. Can we make them so? i.e. check if the entry is already present, and only add it if it is? Same goes for adding a chart. (There's also an issue I've noted where if a chart add fails to vendor, it can still end up in the chart file then block you from re-adding it without editing the chartfile).
|
I'm pretty sure Lines 161 to 164 in 26ffb4c Sure, we can make that for |
malcolmholmes
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tk tool charts add-repo for adding a repository using the CLI
Fixes #417