Normalize paths on windows #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The glob package does not treat path separators as special, so patterns like `**/vendor/**` literally match a path containing `/vendor/`. This breaks down on windows. We can fix this by using filepath.ToSlash(...) to normalize the slash direction when looking for files to format.
This fixes a failing test on windows due to path inconsistent path separators. The test now passes on windows and linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409 by normalizing path separator direction before checking the exclude patterns.
I also found another failing test on windows related to path separators, let me know if you want me to break that out into its own PR. With these changes, all tanka tests are now passing on windows and in a go:1.15 linux docker container.