feat(process): Unwrap List types #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds native support to Tanka for unwrapping List objects, those being k8s pseudo objects used to bundle multiple resources into one object. To detect whether something is a List or not, the existence of `items` is used, the same criteria the offical `k8s.io` packages use: https://github.com/kubernetes/apimachinery/blob/61490fe38e784592212b24b9878306b09be45ab0/pkg/apis/meta/v1/unstructured/unstructured.go#L54
sh0rez
added
kind/feature
Now always gives name, reason and a code sample of the violating object
malcolmholmes
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Tried this out.
Added this out first:
list: {
kind: 'List',
apiVersion: 'v1',
items: [{
kind: 'Deployment',
apiVersion: 'apps/v1',
}],
},
It complained:
.list.items[0] has missing or invalid fields: metadata, metadata.name:
apiVersion: apps/v1
kind: Deployment
Please check above object.
This complaint seems completely reasonable. I followed its instructions:
list: {
kind: 'List',
apiVersion: 'v1',
items: [{
kind: 'Deployment',
apiVersion: 'apps/v1',
metadata: {
name: 'foo',
},
}],
},
This rendered as expected, the deployment was in the list of resources, and there was no list in the output.
mplzik
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds native support to Tanka for unwrapping List objects, those
being k8s pseudo objects used to bundle multiple resources into one
object.
To detect whether something is a List or not, the existence of
itemsis used, the same criteria the offical
k8s.iopackages use:Also refactors SchemaError which is now used in
Unwrapas well. The error now also displays a code snippet, so debugging becomes easierFixes #277