fix(kubernetes): ignore diff errs on apply #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If diff fails, it doesn't mean apply couldn't suceed anyways, so it is wrong to abort in such a case. Changes that behavior so that the diff error is printed, but still continued to applying.
sh0rez
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If diff fails, it doesn't mean apply couldn't succeed anyways, so it is wrong to abort in such a case.
Changes that behavior so that the diff error is printed, but still continued to applying.
This does not fix the actual issue (diff failing for complex reasons), but makes Tanka still usable because after the first apply diff will most probably work again.