Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): restore diff coloring on apply #216

Merged
merged 1 commit into from
Feb 13, 2020
Merged

fix(cli): restore diff coloring on apply #216

merged 1 commit into from
Feb 13, 2020

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Feb 13, 2020 •
edited
Loading

Lost that functionality somewhere during refactoring, but it really aids
readability, so we do need this.

Fixes #209

@sh0rez
fix(cli): restore diff coloring on apply
62d60e0 
Lost that functionality somewhere during refactoring, but it really aids
readability, so we do need this.
@sh0rez sh0rez added kind/bug Something isn't working component/cli Command Line Interface labels Feb 13, 2020
@sh0rez sh0rez requested a review from cstyan February 13, 2020 20:37
cstyan
cstyan approved these changes Feb 13, 2020
View reviewed changes
Copy link

@cstyan cstyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just rebuilt off this branch and colourdiff on apply works again

@sh0rez sh0rez merged commit 683d0e0 into master Feb 13, 2020
@sh0rez sh0rez deleted the apply-color branch February 13, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstyan cstyan cstyan approved these changes

Assignees
No one assigned
Labels
component/cli Command Line Interface kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tk apply diff is not colored anymore
2 participants
@sh0rez @cstyan