fix(cli): paging issues with colored diff #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The less command has two flags: --raw-control-chars and --RAW-CONTROL-CHARS, each of which keeps ASCII control characters present in the paginated output. The former flag was being used previously, and the man page warns about various display problems occurring when using that flag. On the other hand, --RAW-CONTROL-CHARS only keeps color escape sequences, and the man page notes that appearance will be maintained correctly in most cases. In my local testing, this appears to be true and colorized output in less will now work as expected. Fixes grafana#82.
rfratto
force-pushed
the
fix-diff-color-issues
branch
from
16d23f1 to
e9a43dd
Compare
pracucci
reviewed
Feb 12, 2020
sh0rez
approved these changes
Feb 12, 2020
sh0rez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Do not merge until #202 is merged; for this to work correctly it depends on color sequences being applied per line rather than per diff chunk, which is introduced in #202.
The
lesscommand has two flags:--raw-control-charsand--RAW-CONTROL-CHARS, each of which keeps ASCII control characters present in the paginated output. The former flag was being used previously, and the man page warns about various display problems occurring when using that flag.On the other hand,
--RAW-CONTROL-CHARSonly keeps color escape sequences, and the man page notes that appearance will be maintained correctly in most cases. In my local testing, this appears to be true and colorized output in less will now work as expected.Fixes #82.