feat(jsonnet): expose Environment at runtime #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows to use the parsed `spec.json` contents at runtime:
```jsonnet
local tk = import "tk";
{
env: tk.env,
}
```
It also introduces a Tanka native API extension (`import "tk"`), which serves as
a wrapper for all `std.extVar` and `std.nativeFunc` we use, so that we can make
breaking changes to those internals, without affecting the public API.
sh0rez
added
kind/feature
rfratto
reviewed
Jan 13, 2020
pkg/jsonnet/importer.go
Outdated
| } | ||
| } | ||
|
|
||
| // Import implements the functionality offered by the ExtendedImporter | ||
| func (i *ExtendedImporter) Import(importedFrom, importedPath string) (contents jsonnet.Contents, foundAt string, err error) { | ||
| // check if an interceptor handles this |
There was a problem hiding this comment.
Can you help me understand this better? Is the idea that you can only have one interceptor and one postprocessor for a given import at a time? I'd like to see some stronger godocs around these interceptors and processors since the ordering is important (i.e., if two interceptors operate on yaml, only the first will ever be used).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to use the parsed
spec.jsoncontents at runtime:It also introduces a Tanka native API extension (
import "tk"), which serves asa wrapper for all
std.extVarandstd.nativeFuncwe use, so that we can makebreaking changes to those internals, without affecting the public API.
metadata.nameof the Environment is the CLI argument and not the actual name. This is fixed in #131 but not merged yetFixes #161