Alerting: Fix removing reducer when inital value is instant #97054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniaAguilarPeiron
added
type/bug
area/alerting
soniaAguilarPeiron
requested review from
gillesdemey,
tomratcliffe and
konrad147
and removed request for
a team
konrad147
reviewed
Nov 26, 2024
...lerting/unified/components/rule-editor/query-and-alert-condition/QueryAndExpressionsStep.tsx
Show resolved
Hide resolved
|
/deploy-to-hg |
|
|
Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs |
|
/deploy-to-hg |
|
|
Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs |
|
/deploy-to-hg |
|
|
gillesdemey
approved these changes
Nov 27, 2024
gelicia
pushed a commit
that referenced
this pull request
Dec 4, 2024
* Fix removing reducer when inital value is instant * use ID to allow clicking label to toggle the switch --------- Co-authored-by: Gilles De Mey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR initialize the alert rule form when creating a new alert rule with the right removal of reduce expression done when using instant query in Prometheus or Loki data source.
We were removing the reduce expression once user updates something in the editor.
Why do we need this feature?
This removal should be done from the initial render of the form.
Who is this feature for?
All users.
Which issue(s) does this PR fix?:
Fixes #
see problem: https://raintank-corp.slack.com/archives/C01LJ5F8NRX/p1732625698749139
Special notes for your reviewer:
After the fix and clicking new alert rule from the list view:
removeok.mp4
Please check that: