Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grafana UI: Compress grot-cta image #97052

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Grafana UI: Compress grot-cta image #97052

merged 2 commits into from
Nov 28, 2024

Conversation

jackw
Copy link
Contributor

@jackw jackw commented Nov 26, 2024 •
edited
Loading

What is this feature?

This PR reduces the size of the grot-cta.svg image which is crazy large due to the tumbleweed.

Why do we need this feature?

On main branch this image is 800kb. This PR shrinks it to 95kb.

Before After
Screenshot 2024-11-27 at 07 45 21 Screenshot 2024-11-27 at 07 43 57

Who is this feature for?

Performance minded folks

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@jackw jackw added area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Nov 26, 2024
@jackw jackw self-assigned this Nov 26, 2024
@jackw jackw requested a review from a team as a code owner November 26, 2024 15:21
@jackw jackw requested review from aocenas and ashharrison90 and removed request for a team November 26, 2024 15:21
@github-actions github-actions bot added this to the 11.4.x milestone Nov 26, 2024
@joshhunt
Copy link
Contributor

joshhunt commented Nov 26, 2024 •
edited
Loading

image

I haven't looked at this in grafana yet, but has grot lost his outline?

@jackw jackw marked this pull request as draft November 26, 2024 15:25
@jackw jackw changed the title Grafana UI: Reduce grot-cta svg size [WIP] Grafana UI: Reduce grot-cta svg size Nov 26, 2024
@jackw
Copy link
Contributor Author

jackw commented Nov 26, 2024

I haven't looked at this in grafana yet, but has grot lost his outline?

Yeah, sorry I've set it as draft until I get that outline back. 👍

@jackw jackw changed the title [WIP] Grafana UI: Reduce grot-cta svg size Grafana UI: Reduce grot-cta svg size Nov 27, 2024
@jackw jackw changed the title Grafana UI: Reduce grot-cta svg size Grafana UI: Compress grot-cta image Nov 27, 2024
@jackw jackw marked this pull request as ready for review November 27, 2024 06:39
@jackw
Copy link
Contributor Author

jackw commented Nov 27, 2024

Grot and his outlines should be back now. 🎨

@jackw jackw merged commit 10eec83 into main Nov 28, 2024
23 checks passed
@jackw jackw deleted the jackw/mini-grot-cta branch November 28, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clarity-89 Clarity-89 Clarity-89 approved these changes

@aocenas aocenas Awaiting requested review from aocenas aocenas is a code owner automatically assigned from grafana/grafana-frontend-platform

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90 ashharrison90 is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees

@jackw jackw

Labels
area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/performance
Projects
Grafana Frontend Platform
Status: 🚀 Done
Milestone
11.4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@jackw @joshhunt @Clarity-89