MetricCombobox: Fix overflowing parents #97049
Open
+55
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eledobleefe
added
type/bug
area/frontend
no-backport
tskarhed
reviewed
Nov 29, 2024
packages/grafana-prometheus/src/querybuilder/components/MetricCombobox.tsx
Outdated
Show resolved
Hide resolved
tskarhed
reviewed
Nov 29, 2024
| '> div': { | ||
| 'label + div': { | ||
| // Take label and the metrics explorer button into account | ||
| maxWidth: `calc(100% - (160px + 32px))`, |
There was a problem hiding this comment.
Is there any way we could approach this in the InlineFieldRow component without calculating from hardcoded values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
We recently fixed the overflowing issue in the
Comboboxcomponent itself, and now we modify a bit thePromQueryBuilderContainerand theMetricComboboxitself to fix the overflowing there.Why do we need this feature?
To avoid overflowing parent containers.
Who is this feature for?
Everybody using
MetricComboboxWhich issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Before:
metriccombobox.mov
Grabacion.de.pantalla.2024-11-26.a.las.16.17.47.mov
After:
Grabacion.de.pantalla.2024-11-26.a.las.16.24.31.mov
Grabacion.de.pantalla.2024-11-26.a.las.16.23.27.mov
Please check that: