Sandbox loader: Check if it's a grafana org plugin #97035
Closed
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
added
no-backport
tolzhabayev
reviewed
Nov 26, 2024
| if ( | ||
| pluginMeta.signatureType === PluginSignatureType.grafana || | ||
| pluginMeta.signature === 'internal' || | ||
| pluginId.startsWith('grafana-') |
There was a problem hiding this comment.
curious, do we have cases where signatureType is different for grafana- plugins?
There was a problem hiding this comment.
not in the catalog (AFAIK) but it could be unsigned when developing
There was a problem hiding this comment.
I am not convinced with this check. A malicious plugin can potentially escape the sandbox by changing its plugin-id to something starting with grafana-
There was a problem hiding this comment.
plugins cannot change their id 😓 so only unsigned plugins would be able to start with grafana-. In any case, there is no clear use case for this (only for dev), so happy to not include it.
tolzhabayev
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Extend the check to no try to sandbox plugins with
grafanaas its org.