Menu: Change left/right padding to 12px
#97033
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svennergr
added
area/frontend
no-backport
svennergr
requested review from
tskarhed and
JoaoSilvaGrafana
and removed request for
a team
|
Can we add 2px border radius to the menu items so the focus state does not have square corners? |
Done - this is also applied to hover state: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
I think the menu items' left padding is too large (16px):
So I changed it to
theme.spacing(1.5)or12px:To be honest, I think
8pxwould also work, however it's a bit worse with groups:@torkelo: added you because you changed it to 16px a while ago: https://github.com/grafana/grafana/pull/52686/files#diff-4971d5ff63a99a56d662b043f5df3d449788319daf12b657f3cc2b407d2afb58R166