Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zanzana: Use StreamedListObjects to fetch full list of resources #97025

Merged
merged 10 commits into from
Nov 27, 2024

Conversation

alexanderzobnin
Copy link
Contributor

@alexanderzobnin alexanderzobnin commented Nov 26, 2024

What is this feature?

Use StreamedListObjects from openFGA to perform listing. In order to use it, we need to create OpenFGAServiceClient first, because server method is not supposed to use directly, but should be wrapped in grpc connection. It should be enabled in the config:

[zanzana]
use_streamed_list_objects = true

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@alexanderzobnin alexanderzobnin added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes area/authz labels Nov 26, 2024
@alexanderzobnin alexanderzobnin requested a review from a team as a code owner November 26, 2024 10:27
@alexanderzobnin alexanderzobnin requested review from gamab, eleijonmarck, Jguer and kalleep and removed request for a team November 26, 2024 10:27
@github-actions github-actions bot added this to the 11.4.x milestone Nov 26, 2024
@alexanderzobnin alexanderzobnin requested a review from a team as a code owner November 26, 2024 11:20
@alexanderzobnin alexanderzobnin enabled auto-merge (squash) November 27, 2024 10:33
@alexanderzobnin alexanderzobnin merged commit 5a91ab4 into main Nov 27, 2024
13 checks passed
@alexanderzobnin alexanderzobnin deleted the zanzana/streamed-list branch November 27, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/authz area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants