Chrome: Rename golangci.toml into golangci.yml in docs and scripts #97021
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafana-pr-automation
bot
added
type/docs
grafana-pr-automation
bot
added
the
type/ci
baldm0mma
reviewed
Nov 26, 2024
| @@ -9,7 +9,7 @@ include .bingo/Variables.mk | |||
|
|
|||
| GO = go | |||
| GO_VERSION = 1.23.1 | |||
| GO_LINT_FILES ?= $(shell ./scripts/go-workspace/golangci-lint-includes.sh) | |||
There was a problem hiding this comment.
Do we still need this script then?
There was a problem hiding this comment.
Is it used other places?
baldm0mma
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go listto filter Go modules we want to lint in the Makefile (much like we do on CI now)