-
-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goreleaser test #2355
Comments
Reflecting on my experience with I would very much like to see exactly how assets etc will be named. It is a crucial aspect of the release assets that get posted to GitHub that they are named correctly. Consider release https://github.com/cue-lang/cue/releases/tag/v0.4.0 The assets that are created also have I can't see via the existing So being able to supply a the "version" in this test flow would be very useful. (apologies if there is a way of doing this that I have missed!) |
maybe we could revive #1457 and then change the default |
Another drive-by thought, that builds on the idea of being able to "inject" the version (#2355 (comment)): have the output of |
This got missed in the original migration in 06484a3 which replaced github.com/cuelang with github.com/cue-lang. In the GoReleaser config, "cuelang" appeared bare. Per goreleaser/goreleaser#2355 there is no good way to test all parts of a GoReleaser config until release time, hence we continue to iron out these issues in subsequent beta releases. Signed-off-by: Paul Jolly <[email protected]> Change-Id: Iceef1ab52d4f766956c76cd080d30662b0960d56
This got missed in the original migration in 06484a3 which replaced github.com/cuelang with github.com/cue-lang. In the GoReleaser config, "cuelang" appeared bare. Per goreleaser/goreleaser#2355 there is no good way to test all parts of a GoReleaser config until release time, hence we continue to iron out these issues in subsequent beta releases. Signed-off-by: Paul Jolly <[email protected]> Change-Id: Iceef1ab52d4f766956c76cd080d30662b0960d56 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/528590 Unity-Result: CUEcueckoo <[email protected]> TryBot-Result: CUEcueckoo <[email protected]>
This got missed in the original migration in 06484a3 which replaced github.com/cuelang with github.com/cue-lang. In the GoReleaser config, "cuelang" appeared bare. Per goreleaser/goreleaser#2355 there is no good way to test all parts of a GoReleaser config until release time, hence we continue to iron out these issues in subsequent beta releases. Signed-off-by: Paul Jolly <[email protected]> Change-Id: Iceef1ab52d4f766956c76cd080d30662b0960d56 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/528590 Unity-Result: CUEcueckoo <[email protected]> TryBot-Result: CUEcueckoo <[email protected]> Signed-off-by: Joel Longtine <[email protected]>
Another possible idea of implementation, which I think lives here as well: IMHO, the E.g., I use an At least for me, most of my mistakes consist of forgetting to wire some environment variable in some workflow somewhere, so having that would be amazing :) |
I think this case is somewhat more tricky. Because often people rely on the semantics of an environment variable not being return What might be interesting to explore is whether, with CUE-based configured/constraints, "required" environment variables that must be set (to a non-empty string value) would help. |
The current GoReleaser version is old, and the action@v2 uses the deprecated node v12 environment. https://github.com/cue-lang/cue/actions/runs/3489028415 Upgrade the action and goreleaser whilst we are at it. This has been "tested" locally via: goreleaser --snapshot --rm-dist but will be tested completely by creating a real v0.0.0-goreleaser.N release to ensure it works. This is pending a proper test setup from goreleaser: goreleaser/goreleaser#2355 Signed-off-by: Paul Jolly <[email protected]> Change-Id: Ief23c3b9e7b3d422ae3330dc463d9770aae046fd
The current GoReleaser version is old, and the action@v2 uses the deprecated node v12 environment. https://github.com/cue-lang/cue/actions/runs/3489028415 Upgrade the action and goreleaser whilst we are at it. This has been "tested" locally via: goreleaser --snapshot --rm-dist but will be tested completely by creating a real v0.0.0-goreleaser.N release to ensure it works. This is pending a proper test setup from goreleaser: goreleaser/goreleaser#2355 Signed-off-by: Paul Jolly <[email protected]> Change-Id: Ief23c3b9e7b3d422ae3330dc463d9770aae046fd Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/546295 Unity-Result: CUEcueckoo <[email protected]> TryBot-Result: CUEcueckoo <[email protected]> Reviewed-by: Daniel Martí <[email protected]>
Interestingly, we were using
This sort of sounds like a bug in itself, caused by
Note that if you
|
Note that I got pretty close to having something like |
After hitting a few issues in our release process as well (luckily, so far, all build related), I think it'd be great to have the inverse process:
Importantly, 3 doesn't incur a rebuild and 2 executes on the release artifacts so we have greater confidence in them. My understanding is that |
Would be good to have a
goreleaser test
command that does the following:The idea came while working with @myitcv on cue-lang/cue#1105
The text was updated successfully, but these errors were encountered: