Add a save button to the media controller tester app, #27
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
@googlebot I signed it! |
|
@googlebot I fixed it. |
| toast.show(); | ||
| return; | ||
| } | ||
| File root = android.os.Environment.getExternalStorageDirectory(); |
There was a problem hiding this comment.
This bit of code won't work on Android 11 and above because of changes for scoped storage.
If possible, I think it would be best to change this to use the Storage Access Framework with the intent action ACTION_CREATE_DOCUMENT -- this would not only allow the code to work on Android 11 and beyond, but would allow the user to pick the name & location to put the file.
The intent returns a URI in the form of content://... that can be used with ContentResolver to open an output stream, which seems like it should work with the rest of the code you have below.
| @@ -17,6 +17,7 @@ | |||
| xmlns:tools="http://schemas.android.com/tools" | |||
| package="com.example.android.mediacontroller"> | |||
|
|
|||
| <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/> | |||
There was a problem hiding this comment.
This actually doesn't work when targeting Android Q+ because of scoped storage changes. It could work on Android Q, but I think it would be better to use the Storage Access Framework for this, which wouldn't require any permissions and would let the user pick where to put the file (I explained more below, but just adding this here so I don't miss this permission being removed if you go that route.
Hi,
This pr is to create a save button in the media browse tree view, so that we can save the content of the browse tree to device, and later on transfer to computer for more analysis.
This change is in response to the request for assistant features on radio station names. To better support radio station names, we would need to analyze on the contents of the radio browser, and MCT would be a good way for us to communicate with partners to ask them to help us on getting this data.
Best,