Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: google-gax resolution #1333

Merged
merged 4 commits into from
Sep 9, 2022
Merged

fix: google-gax resolution #1333

merged 4 commits into from
Sep 9, 2022

Conversation

CorentinAndre
Copy link
Contributor

@CorentinAndre CorentinAndre commented Sep 8, 2022 •
edited
Loading

Hi 👋

This fixes #1332 🦕

@CorentinAndre CorentinAndre requested review from a team as code owners September 8, 2022 10:09
@google-cla
Copy link

google-cla bot commented Sep 8, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/nodejs-logging API. labels Sep 8, 2022
@losalex losalex assigned losalex and unassigned daniel-sanche Sep 8, 2022
losalex
losalex reviewed Sep 8, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@losalex losalex added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2022
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@losalex losalex added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@losalex losalex merged commit 4491646 into googleapis:main Sep 9, 2022
@release-please release-please bot mentioned this pull request Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losalex losalex losalex approved these changes

Assignees

@losalex losalex

Labels
api: logging Issues related to the googleapis/nodejs-logging API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect dependency resolution: google-gax
5 participants
@CorentinAndre @losalex @daniel-sanche @alexander-fenster @yoshi-kokoro