Closed
Description
Hi 👋 There is an issue with the pinned version of google-gax dependency.
Environment details
- OS: Mac OS 12.4
- Node.js version: 16.16
- npm version: 8.11.0
@google-cloud/logging
version: 10.8.0
Steps to reproduce
- In google-gax lib, protobuf is exported since 3.3.0 => https://github.com/googleapis/gax-nodejs/blob/main/CHANGELOG.md#330-2022-08-26
- A PR is created on this repo to use google-gax 3.3.0 => fix: do not import the whole google-gax from proto JS (#1553) #1321
- This is released in v10.5.0
The problem is that the resolution for google-gax in the package.json is 3.2.2, so people (like me), who bumped the lib from 10.1.x to 10.1.5 and later, still have the google-gax dependency installed with the version 3.2.2.
And when the lib is exporting this module.exports = factory(require("google-gax/build/src/protobuf").protobufMinimal);
, it throws an error because it does not exist as it is only available in google-gax 3.3.0 and after.