Skip to content

Add support for Python 3.6. #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add support for Python 3.6. #2902

wants to merge 2 commits into from

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 28, 2016

I don't think Travis or Appveyor support 3.6 yet.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 28, 2016
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -14,7 +14,6 @@

import os

from setuptools import find_packages

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Dec 28, 2016

@jonparrott @tseaver Have you heard of anyone dropping support for 3.4 / not testing 3.4 in CI any longer?

Already after adding 3.5 our "full" builds time out half the time on Travis

@tseaver
Copy link
Contributor Author

tseaver commented Dec 28, 2016

@dhermes I'm contemplating trying to speed the build up by dropping our hacked-around namespace stuff: a quick test seems to indicate that pip install -e now works.

@dhermes
Copy link
Contributor

dhermes commented Dec 28, 2016

@tseaver I welcome the change. That'll just require lower bounds on pip / setuptools in our CircleCI / Travis / AppVeyor configs?

@lukesneeringer
Copy link
Contributor

Travis and CircleCI both have Python 3.6 support now. :-)

@theacodes
Copy link
Contributor

Ya'll will probably need to wait on grpc/grpc#9445 just like google-auth googleapis/google-auth-library-python#102

@lukesneeringer
Copy link
Contributor

This is available now, but I am actually closing this because I am working on a more dramatic overhaul of our testing tooling.

@tseaver tseaver deleted the python-3.6-support branch April 25, 2017 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. packaging testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants