fix(logging): added marshalling methods for proto fields in structuredLogEntry #8979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
structuredLogEntry
product-auto-label
bot
added
size: m
bhshkh
reviewed
Nov 7, 2023
| TraceSampled bool `json:"logging.googleapis.com/trace_sampled,omitempty"` | ||
| Message json.RawMessage `json:"message"` | ||
| Severity string `json:"severity,omitempty"` | ||
| HTTPRequest *structuredLogEntryHTTPRequest `json:"httpRequest,omitempty"` |
Contributor
There was a problem hiding this comment.
Since datatype of HTTPRequest is being changed, this can be a breaking change if the user is able to access this field. I see that structuredLogEntry type itself is unexported. So, it is highly unlikely but please recheck the rest of the logging code to ensure the same.
bhshkh
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7785 while still maintaining camelCase keys when marshalling proto objects.