fix(spanner): handle errors (#10943)

Co-authored-by: rahul2393 <[email protected]>
googleapis · Oct 3, 2024 · c67f964 · c67f964
1 parent 0b4c4e7
commit c67f964
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/spanner/metrics.go b/spanner/metrics.go
@@ -264,6 +264,9 @@ func (tf *builtinMetricsTracerFactory) createInstruments(meter metric.Meter) err
 		metric.WithDescription("The count of database operations."),
 		metric.WithUnit(metricUnitCount),
 	)
+	if err != nil {
+		return err
+	}
 
 	// Create attempt_count
 	tf.attemptCount, err = meter.Int64Counter(

diff --git a/spanner/transaction_test.go b/spanner/transaction_test.go
@@ -575,6 +575,9 @@ func TestReadWriteStmtBasedTransactionWithOptions(t *testing.T) {
 			break
 		} else if err == nil {
 			resp, err = tx.CommitWithReturnResp(ctx)
+			if err != nil {
+				t.Fatalf("failed to CommitWithReturnResp: %v", err)
+			}
 			break
 		}
 		// Set a default sleep time if the server delay is absent.