fix(spanner): check errors in tests (#10738)

* fix(spanner): add missing error checks to tests * fix(spanner): check error before using client in test * chore(spanner): remove redundant return-s --------- Co-authored-by: rahul2393 <[email protected]>
googleapis · Sep 25, 2024 · 971bfb8 · 971bfb8
1 parent 6fbd687
commit 971bfb8
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/spanner/client_test.go b/spanner/client_test.go
@@ -3144,7 +3144,6 @@ func TestClient_ReadWriteTransactionConcurrentQueries(t *testing.T) {
 				}
 				rowCount++
 			}
-			return
 		}
 		wg.Add(2)
 		go query(&firstTransactionID)
@@ -4720,10 +4719,10 @@ func TestClient_EmulatorWithCredentialsFile(t *testing.T) {
 		"localhost:1234",
 		opts...,
 	)
-	defer client.Close()
 	if err != nil {
 		t.Fatalf("Failed to create a client with credentials file when running against an emulator: %v", err)
 	}
+	defer client.Close()
 }
 
 func TestBatchReadOnlyTransaction_QueryOptions(t *testing.T) {

diff --git a/spanner/session.go b/spanner/session.go
@@ -761,7 +761,6 @@ func newSessionPool(sc *sessionClient, config SessionPoolConfig) (*sessionPool,
 			// wait for the session to be created
 			case <-pool.mayGetMultiplexedSession:
 			}
-			return
 		}()
 	}
 	pool.recordStat(context.Background(), MaxAllowedSessionsCount, int64(config.MaxOpened))

diff --git a/spanner/transaction_test.go b/spanner/transaction_test.go
@@ -565,6 +565,10 @@ func TestReadWriteStmtBasedTransactionWithOptions(t *testing.T) {
 			client,
 			TransactionOptions{CommitOptions: CommitOptions{ReturnCommitStats: true}},
 		)
+		if err != nil {
+			t.Fatalf("failed to create transaction: %v", err)
+		}
+
 		_, err = f(tx)
 		if err != nil && status.Code(err) != codes.Aborted {
 			tx.Rollback(ctx)
@@ -592,6 +596,10 @@ func TestBatchDML_StatementBased_WithMultipleDML(t *testing.T) {
 	defer teardown()
 
 	tx, err := NewReadWriteStmtBasedTransaction(ctx, client)
+	if err != nil {
+		t.Fatalf("failed to create transaction: %v", err)
+	}
+
 	if _, err = tx.Update(ctx, Statement{SQL: UpdateBarSetFoo}); err != nil {
 		tx.Rollback(ctx)
 		t.Fatal(err)
@@ -653,6 +661,10 @@ func TestPriorityInQueryOptions(t *testing.T) {
 	defer teardown()
 
 	tx, err := NewReadWriteStmtBasedTransaction(ctx, client)
+	if err != nil {
+		t.Fatalf("failed to create transaction: %v", err)
+	}
+
 	var iter *RowIterator
 	iter = tx.txReadOnly.Query(ctx, NewStatement("SELECT 1"))
 	err = iter.Do(func(r *Row) error { return nil })