Skip to content

Fix ID token verification #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theacodes merged 2 commits into from
Nov 17, 2016
Merged

Fix ID token verification #87

theacodes merged 2 commits into from
Nov 17, 2016

Conversation

@theacodes
Copy link
Contributor

@theacodes theacodes commented Nov 16, 2016 •
edited
Loading

  • Fix call to transport.Request.
  • Make jwt support base64 strings lacking padding characters.

dhermes
dhermes reviewed Nov 16, 2016
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You say "Fix", where was the break exposed?

google/auth/_helpers.py Outdated
bytes: The decoded value
"""
b64string = to_bytes(value)
padded = b64string + b'=' * (4 - len(b64string) % 4)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes
Copy link
Contributor Author

theacodes commented Nov 16, 2016

@dhermes when replacing some hand-rolled code that verified firebase auth tokens for an app engine sample.

@theacodes theacodes merged commit 97eb870 into master Nov 17, 2016
@theacodes theacodes deleted the fix-verification branch November 17, 2016 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dhermes dhermes dhermes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theacodes @dhermes