fix: disable warning if quota project id provided to auth.default() #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
tseaver
suggested changes
Sep 3, 2021
arithmetic1728
force-pushed
the
silent_error
branch
from
6c683f3
to
0d57087
Compare
|
@tseaver added more tests to directly test the expected behavior |
tseaver
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If quota_project_id is provided via
google.auth.default(quota_project_id="my_id"), then we pass the quota_project_id all the way down toload_credentials_from_file. In this case the created user credentials will have thequota_project_idset even if it is not available from the json file, so the users won't see the warning.Fixes: #769