-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add api key support #826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Aug 5, 2021
arithmetic1728
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Aug 6, 2021
arithmetic1728
force-pushed
the
apikeyheader
branch
from
August 16, 2021 20:15
385c113
to
56cf26a
Compare
busunkim96
approved these changes
Sep 2, 2021
arithmetic1728
force-pushed
the
apikeyheader
branch
2 times, most recently
from
September 8, 2021 00:11
9ea731c
to
1eabe0a
Compare
arithmetic1728
force-pushed
the
apikeyheader
branch
from
January 19, 2022 01:26
1eabe0a
to
e9ba514
Compare
arithmetic1728
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jan 19, 2022
busunkim96
approved these changes
Jan 19, 2022
Co-authored-by: Bu Sun Kim <[email protected]>
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 20, 2022
🤖 I have created a release *beep* *boop* --- ## [2.4.0](v2.3.3...v2.4.0) (2022-01-20) ### Features * add 'py.typed' declaration ([#919](#919)) ([c993504](c993504)) * add api key support ([#826](#826)) ([3b15092](3b15092)) ### Bug Fixes * **deps:** allow cachetools 5.0 for python 3.7+ ([#937](#937)) ([1eae37d](1eae37d)) * fix the message format for metadata server exception ([#916](#916)) ([e756f08](e756f08)) ### Documentation * fix intersphinx link for 'requests-oauthlib' ([#921](#921)) ([967be4f](967be4f)) * note ValueError in `verify_oauth2_token` ([#928](#928)) ([82bc5f0](82bc5f0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
arithmetic1728
added a commit
that referenced
this pull request
Jan 28, 2022
This reverts commit 3b15092.
arithmetic1728
added a commit
that referenced
this pull request
Jan 31, 2022
This reverts commit 3b15092. Co-authored-by: Anthonios Partheniou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds API key support. Internal doc: go/gapic-api-key-support
(1) created a new credential class for API key. The credential adds API key to
x-goog-api-key
header.(2) The new ADC logic is:
GOOGLE_API_KEY
andGOOGLE_APPLICATION_CREDENTIALS
are set, raise an exceptionGOOGLE_API_KEY
is set then return an API key credential; otherwise use the existing ADC flow