Skip to content

Add google.auth.credentials - the public interfaces for credentials #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theacodes merged 8 commits into from
Oct 14, 2016
Merged

Add google.auth.credentials - the public interfaces for credentials #8

theacodes merged 8 commits into from
Oct 14, 2016

Conversation

@theacodes
Copy link
Contributor

@theacodes theacodes commented Oct 4, 2016

@nathanielmanistaatgoogle this is the section you indicated you wanted to give input on. PTAL.

@theacodes theacodes added this to the 1.0.0 milestone Oct 4, 2016
@theacodes
Copy link
Contributor Author

theacodes commented Oct 4, 2016

I am unsure if I should leave the scopes property as is (completely private) or make it a public read-only property.

@dhermes
Copy link
Contributor

dhermes commented Oct 4, 2016

I vote for public read-only. I'm holding off a review here until you tell me to look @jonparrott

@theacodes
Copy link
Contributor Author

theacodes commented Oct 4, 2016

Sgtm, gonna let Nathaniel chime in first.

On Tue, Oct 4, 2016, 3:08 PM Danny Hermes [email protected] wrote:

I vote for public read-only. I'm holding off a review here until you tell
me to look @jonparrott https://github.com/jonparrott

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc-0omIhmwrF0HlyVl8t7Mu8-MKApks5qws5igaJpZM4KOMdL
.

@theacodes
Copy link
Contributor Author

theacodes commented Oct 10, 2016

@nathanielmanistaatgoogle ping, this is now blocking.

@dhermes
Copy link
Contributor

dhermes commented Oct 10, 2016

@jonparrott rebase?

@theacodes
Copy link
Contributor Author

theacodes commented Oct 10, 2016

@dhermes doing it now.

@theacodes
Copy link
Contributor Author

theacodes commented Oct 10, 2016

Rebased.

@theacodes theacodes mentioned this pull request Oct 10, 2016
Closed
nathanielmanistaatgoogle
nathanielmanistaatgoogle reviewed Oct 10, 2016
View reviewed changes
google/auth/credentials.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/credentials.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/credentials.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/credentials.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/credentials.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/credentials.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/credentials.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/credentials.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/credentials.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes theacodes mentioned this pull request Oct 14, 2016
Merged
@theacodes
Copy link
Contributor Author

theacodes commented Oct 14, 2016

@nathanielmanistaatgoogle after discussing with @dhermes offline, I'm gonna go ahead and merge this so we can unblock reviewing some concrete classes.

We can still continue to discuss here and I'll send follow-up PRs to make changes. This is all fluid until 1.0. Unless there is a very significant change I don't anticipate the impact on concrete classes to be large.

@theacodes theacodes merged commit 71ce2a0 into master Oct 14, 2016
@theacodes theacodes deleted the credentials-abc branch October 14, 2016 21:08
@renovate-bot renovate-bot mentioned this pull request May 31, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@elibixby elibixby elibixby left review comments

@nathanielmanistaatgoogle nathanielmanistaatgoogle nathanielmanistaatgoogle left review comments

@dhermes dhermes dhermes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@theacodes @dhermes @elibixby @nathanielmanistaatgoogle @bjwatson