Skip to content

Add with_scopes_if_required helper #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theacodes merged 1 commit into from
Oct 31, 2016
Merged

Add with_scopes_if_required helper #65

theacodes merged 1 commit into from
Oct 31, 2016

Conversation

@theacodes
Copy link
Contributor

@theacodes theacodes commented Oct 31, 2016

This will make it easy to remove some code / branches in google-cloud-python.

@theacodes theacodes changed the title Add created_scoped_if_required helper Add create_scoped_if_required helper Oct 31, 2016
@theacodes theacodes changed the title Add create_scoped_if_required helper Add with_scopes_if_required helper Oct 31, 2016
dhermes
dhermes approved these changes Oct 31, 2016
View reviewed changes
tests/test_credentials.py

assert scoped_credentials is not unscoped_credentials
assert not scoped_credentials.requires_scopes
assert scoped_credentials.has_scopes(['one', 'two'])

This comment was marked as spam.

Sign in to view

@theacodes theacodes merged commit f89a3cf into master Oct 31, 2016
@theacodes theacodes deleted the with-scopes-if-required branch October 31, 2016 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dhermes dhermes dhermes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theacodes @dhermes