feat: add asyncio based auth flow #612

crwilcox · 2020-09-25T19:23:32Z

All code in this PR has been reviewed up to this point and been added to the 'async' branch.

I would recommend being mindful of changes to existing sync based files for possible merge gotchas.

…572) * asyncio http request logic. * asynchronous credentials functionality.

…on types (service accounts, default... etc) (#573) * feat: asyncio http request logic and asynchronous credentials log c * feat: all asynchronous credentials types implemented and with tests * feat: added the private scope for Response class * feat: added docstring for Auth Session request method * fix: Changed initialization of client session to within an async context manager * changed aiohttp_requests abbreviation for the async authorized session class * fix: changed abbrevation of the aiohttp_requests file * fix: comments on PR regarding shared data between requests and aiohttp_requests * fix: fixed noxfile test dependency sharing * fix: fixed the noxfile dependencies between sync and async unit tests * fix: cover async dependency * fix: merge conflict issue with credentials * fix: merge conflict #2 * fix: changed duplicated constants for sync-->async inheritance relationship * fix: async docstring * refactoring * fix: refactoring * fix: first round of comments, refactoring and test duplication changes * fix: removed duplication in _default_async * fix: removed oauth2 client

…ken credentials (#574) * feat: asyncio http request logic and asynchronous credentials log c * feat: all asynchronous credentials types implemented and with tests * included system tests for the asynchronous auth library * feat: added the private scope for Response class * feat: added docstring for Auth Session request method * fix: Changed initialization of client session to within an async context manager * changed aiohttp_requests abbreviation for the async authorized session class * fix: changed abbrevation of the aiohttp_requests file * fix: comments on PR regarding shared data between requests and aiohttp_requests * fix: fixed noxfile test dependency sharing * fix: fixed the noxfile dependencies between sync and async unit tests * fix: cover async dependency * fix: merge conflict issue with credentials * fix: merge conflict #2 * fix: changed duplicated constants for sync-->async inheritance relationship * fix: async docstring * refactoring * fix: refactoring * fix: first round of comments, refactoring and test duplication changes * fix: removed duplication in _default_async * compute engine and metadata changes * fix: removed oauth2 client * added further system tests and refactored * modified aiohttp request docstring * refactoring and fixing comments * refactored system tests and re-wrote nox file * metadata typo * fix: nox file tests added * fix: directory path in app_engine

* fix: use urllib3 inflation of deflated payloads * fix: lint * fix: trailing whitespace

* fix: move async surfaces to internal until stabilized

google-cla · 2020-09-25T19:23:43Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-25T19:25:37Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google/auth/__init__.py

google/auth/credentials_async.py

google/oauth2/credentials_async.py

google/oauth2/id_token_async.py

google/oauth2/service_account_async.py

google-cla · 2020-09-25T21:17:15Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-25T21:22:17Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-25T21:40:57Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-26T00:34:45Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-26T04:36:31Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

* refactor: split 'with_quota_project' into separate base class (#561) Co-authored-by: Tres Seaver <[email protected]> * fix: dummy commit to trigger a auto release (#597) * chore: release 1.21.1 (#599) * chore: updated CHANGELOG.md [ci skip] * chore: updated setup.cfg [ci skip] * chore: updated setup.py Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * fix: migrate signBlob to iamcredentials.googleapis.com (#600) Migrate signBlob from iam.googleapis.com to iamcredentials.googleapis.com. This API is deprecated and will be shutdown in one year. This is used google.auth.iam.Signer. Added a system_test to sanity check the implementation. * chore: release 1.21.2 (#601) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * fix: fix expiry for `to_json()` (#589) * This patch for </issues/501> includes the following fixes: - The access token is always set to `None`, so the fix involves using (the access) `token` from the saved JSON credentials file. - For refresh needs, `expiry` also needs to be saved via `to_json()`. - DUMP: As `expiry` is a `datetime.datetime` object, serialize to `datetime.isoformat()` in the same [`oauth2client` format](https://github.com/googleapis/oauth2client/blob/master/oauth2client/client.py#L55) for consistency. - LOAD: Add code to restore `expiry` back to `datetime.datetime` object when imported. - LOAD: If `expiry` was unsaved, automatically set it as expired so refresh takes place. - Minor `scopes` updates - DUMP: Add property for `scopes` so `to_json()` can grab it - LOAD: `scopes` may be saved as a string instead of a JSON array (Python list), so ensure it is Sequence[str] when imported. * chore: add default CODEOWNERS (#609) * chore: release 1.21.3 (#607) * feat: add asyncio based auth flow (#612) * feat: asyncio http request logic and asynchronous credentials logic (#572) Co-authored-by: Anirudh Baddepudi <[email protected]> * chore: release 1.22.0 (#615) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * fix: move aiohttp to extra as it is currently internal surface (#619) Fix #618. Removes aiohttp from required dependencies to lessen dependency tree for google-auth. This will need to be looked at again as more folks use aiohttp and once the surfaces goes to public visibility. * chore: release 1.22.1 (#620) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * fix: remove checks for ancient versions of Cryptography (#596) Refs #595 (comment) I see no point in checking whether someone is running a version of https://github.com/pyca/cryptography/ from 2014 that doesn't even compile against modern versions of OpenSSL anymore. * chore: sync to master Syncs to master. Fixes broken unit tests in Python 3.6 and 3.7. Aligns test_identity_pool.py with test_aws.py. Co-authored-by: Bu Sun Kim <[email protected]> Co-authored-by: Tres Seaver <[email protected]> Co-authored-by: arithmetic1728 <[email protected]> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: wesley chun <[email protected]> Co-authored-by: Christopher Wilcox <[email protected]> Co-authored-by: Anirudh Baddepudi <[email protected]> Co-authored-by: Aarni Koskela <[email protected]>

anibadde and others added 9 commits July 28, 2020 18:53

feat: asyncio http request logic and asynchronous credentials logic (#…

8d0bca1

…572) * asyncio http request logic. * asynchronous credentials functionality.

feat: gzip/decompressed response content handling (#584)

e963b33

fix: use urllib3 inflation of deflated payloads (#586)

42420b5

* fix: use urllib3 inflation of deflated payloads * fix: lint * fix: trailing whitespace

fix(dependencies): require aiohttp for version >3.5 (#602)

188f549

docs: timeout docs updated to reflect aiohttp timeouts (#610)

a7de807

fix(dependencies): Further restrict aiohttp version

c9adc27

fix: move async to internal surface until stabilized (#611)

52162dc

* fix: move async surfaces to internal until stabilized

crwilcox requested a review from a team as a code owner September 25, 2020 19:23

google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 25, 2020

Merge branch 'master' into async-to-master

15eba5e

crwilcox commented Sep 25, 2020

View reviewed changes

crwilcox added 2 commits September 25, 2020 14:02

fix: move remaining new async surfaces to internal paths

565e2cb

refactor: port #561 split 'with_quota_project' into separate base class

072283e

crwilcox added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2020

google-cla bot removed the cla: no This human has *not* signed the Contributor License Agreement. label Sep 25, 2020

fix: remove default_async from top-level google.auth

629e861

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 25, 2020

crwilcox mentioned this pull request Sep 25, 2020

Move async interfaces to public surface once integrated #613

Open

crwilcox added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 25, 2020

chore: flake8 changes

04f545a

google-cla bot removed the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2020

google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 25, 2020

crwilcox added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 25, 2020

crwilcox added 2 commits September 25, 2020 15:43

test: bad reference in system test

21b84cc

test: improve coverage

f960381

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 26, 2020

crwilcox mentioned this pull request Sep 26, 2020

coverage: improve test coverage for aiohttp_requests.py #614

Closed

9 tasks

crwilcox added cla: yes This human has signed the Contributor License Agreement. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 26, 2020

google-cla bot removed the cla: no This human has *not* signed the Contributor License Agreement. label Sep 26, 2020

chore: lint

83e545c

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 26, 2020

yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 26, 2020

crwilcox added cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 26, 2020

busunkim96 approved these changes Sep 28, 2020

View reviewed changes

crwilcox merged commit 7e15258 into master Sep 28, 2020

tseaver deleted the async-to-master branch October 28, 2020 18:41

bradreardon mentioned this pull request Apr 8, 2021

FR: Async requests firebase/firebase-admin-python#104

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add asyncio based auth flow #612

feat: add asyncio based auth flow #612

crwilcox commented Sep 25, 2020 •

edited

Loading

google-cla bot commented Sep 25, 2020

google-cla bot commented Sep 25, 2020

google-cla bot commented Sep 25, 2020

google-cla bot commented Sep 25, 2020

google-cla bot commented Sep 25, 2020

google-cla bot commented Sep 26, 2020

google-cla bot commented Sep 26, 2020

feat: add asyncio based auth flow #612

feat: add asyncio based auth flow #612

Conversation

crwilcox commented Sep 25, 2020 • edited Loading

google-cla bot commented Sep 25, 2020

google-cla bot commented Sep 25, 2020

google-cla bot commented Sep 25, 2020

google-cla bot commented Sep 25, 2020

google-cla bot commented Sep 25, 2020

google-cla bot commented Sep 26, 2020

google-cla bot commented Sep 26, 2020

crwilcox commented Sep 25, 2020 •

edited

Loading