Skip to content

Adding ADC system tests #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theacodes merged 1 commit into from
Oct 27, 2016
Merged

Adding ADC system tests #58

theacodes merged 1 commit into from
Oct 27, 2016

Conversation

@theacodes
Copy link
Contributor

@theacodes theacodes commented Oct 26, 2016

Towards #55

@theacodes theacodes added this to the 1.0.0 milestone Oct 26, 2016
@theacodes theacodes mentioned this pull request Oct 26, 2016
Merged
dhermes
dhermes approved these changes Oct 27, 2016
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though it isn't really a system test since you patch/mock so many things

@theacodes theacodes merged commit 421cc9b into master Oct 27, 2016
@theacodes theacodes deleted the adc-system-tests branch October 27, 2016 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dhermes dhermes dhermes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@theacodes @dhermes