Skip to content

fix: catch exceptions.RefreshError #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
busunkim96 merged 1 commit into from
May 11, 2020
Merged

fix: catch exceptions.RefreshError #508

busunkim96 merged 1 commit into from
May 11, 2020

Conversation

@arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented May 8, 2020 •
edited
Loading

Should catch the RefreshError raised by credentials.refresh(request). This should be the cause or at least part of the cause of issue: GoogleCloudPlatform/python-docs-samples#3712

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2020
@arithmetic1728 arithmetic1728 requested a review from busunkim96 May 11, 2020 18:21
@busunkim96 busunkim96 merged commit 3d672e9 into master May 11, 2020
@arithmetic1728 arithmetic1728 deleted the sijun/fix_idtoken branch May 11, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arithmetic1728 @busunkim96 @googlebot