Add retry loop for fetching authentication token if any 'Internal Failure' occurs #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 6, 2019 16:56
…lure' occurs This is to prevent errors while client tries to connect with server and fails with 'Internal Failure' because it was unable to fetch OAuth2 token.
…lure' occurs This is to prevent errors while client tries to connect with server and fails with 'Internal Failure' because it was unable to fetch OAuth2 token.
googlebot
added
the
cla: yes
busunkim96
reviewed
Sep 9, 2019
busunkim96
approved these changes
Sep 9, 2019
Contributor
|
Hi. I have the same issue and a retry would help. But I think there is a mistake in the current implementation. You are right, the error looks like that: RefreshError: ('internal_failure: None', u'{\n "error": "internal_failure"\n}') {"error": "internal_failure"} |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent errors when client tries to connect with server and fails to fetch OAuth2 token throwing 'Internal Failure'.
Bug - https://bugs.chromium.org/p/chromium/issues/detail?id=1001206