Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add smbios check to detect GCE residency #1276

Merged
merged 2 commits into from
Apr 28, 2023
Merged

feat: Add smbios check to detect GCE residency #1276

merged 2 commits into from
Apr 28, 2023

Conversation

wangyutongg
Copy link
Contributor

Add static detection on Google hardware. Current detection on meta data server is not stable. For more details: go/auth-library-noping

Fixes: #1232

@wangyutongg wangyutongg marked this pull request as ready for review April 18, 2023 20:16
@wangyutongg wangyutongg requested review from a team as code owners April 18, 2023 20:16
clundin25
clundin25 approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@clundin25 clundin25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@wangyutongg wangyutongg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@wangyutongg wangyutongg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2023
@wangyutongg wangyutongg merged commit 22d241b into main Apr 28, 2023
@wangyutongg wangyutongg deleted the yutong-gce-detection branch April 28, 2023 02:00
@release-please release-please bot mentioned this pull request Apr 28, 2023
Merged
@clundin25 clundin25 mentioned this pull request Apr 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clundin25 clundin25 clundin25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve GCE detection by checking Google hardware
4 participants
@wangyutongg @clundin25 @yoshi-kokoro @arithmetic1728