Aws cloudtrail tagger #3224
Merged
Aws cloudtrail tagger #3224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @jkppr, Could you please review the PR when you have a moment? |
jkppr
approved these changes
Nov 12, 2024
Collaborator
jkppr
left a comment
jkppr
left a comment
There was a problem hiding this comment.
LGTM
Thanks a lot for contributing those tag configs! I'll need to fix the unit tests (unrelated to this PR) and will merge it afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All Pull Requests should be connected to an issue, if you don't
have an issue, please start by creating an issue and link it to the PR.
Please provide enough information so that others can review your pull request:
What existing problem does this PR solve?
data/tags.yaml.What new feature is being introduced with this PR?
Taggeranalyzer.Checks
Closing issues
closes #3216