Skip to content

Commit

Permalink
Remove a workaround code for Visual C++ 2010 (KB813540)
Browse files Browse the repository at this point in the history
Mozc no longer supports Visual C++ 2010.  We don't need to work around KB813540 anymore.
http://support.microsoft.com/kb/813540

This is just a removal of dead code.  No behavior change is intended.

BUG=none
TEST=compile

git-svn-id: https://mozc.googlecode.com/svn/trunk@510 a6090854-d499-a067-5803-1114d4e51264
  • Loading branch information
yukawa committed Jan 25, 2015
1 parent 1423238 commit 091dc3b
Show file tree
Hide file tree
Showing 68 changed files with 66 additions and 187 deletions.
3 changes: 1 addition & 2 deletions src/base/update_checker.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
#include <Windows.h>
#include <tchar.h>
#include <strsafe.h>
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlcom.h>

#include <string>
Expand Down
3 changes: 1 addition & 2 deletions src/base/win_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,9 @@
#include <Psapi.h>
#include <Winternl.h>

// Workaround against KB813540
#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
#include <atlbase_mozc.h>
#include <atlbase.h>

#include <clocale>
#include <memory>
Expand Down
3 changes: 1 addition & 2 deletions src/config/stats_config_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@
#include <shlobj.h>
#include <time.h>
#include <sddl.h>
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#else
#include <pwd.h>
#include <sys/stat.h>
Expand Down
3 changes: 1 addition & 2 deletions src/gui/base/win_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@
#include <vssym32.h>
#include <windows.h>
#include <winuser.h>
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlcom.h>
#include <atlstr.h>
#include <atlwin.h>
Expand Down
5 changes: 0 additions & 5 deletions src/gyp/common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -684,11 +684,6 @@
'include_dirs': [
'<@(msvs_includes)',
'<(additional_third_party_dir)/wtl/files/include',
# Add atl_wrapper dir into the 'include_dirs' so that we can
# include the header file as <atlbase_mozc.h>, which
# is more lintian-friendly than "atlbase_mozc.h".
# See b/5101916 for the background information.
'<(DEPTH)/win32/atl_wrapper',
],
'msvs_cygwin_shell': 0,
'msvs_disabled_warnings': ['<@(msvc_disabled_warnings)'], # /wdXXXX
Expand Down
2 changes: 1 addition & 1 deletion src/mozc_version_template.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MAJOR=2
MINOR=16
BUILD=2036
BUILD=2037
REVISION=102
# NACL_DICTIONARY_VERSION is the target version of the system dictionary to be
# downloaded by NaCl Mozc.
Expand Down
3 changes: 1 addition & 2 deletions src/renderer/renderer_style_handler.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
#include <windows.h>
#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlapp.h>
#include <atlgdi.h>
#endif // OS_WIN
Expand Down
3 changes: 1 addition & 2 deletions src/renderer/win32/candidate_window.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
#include <windows.h>
#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlwin.h>
#include <atlapp.h>
#include <atlcrack.h>
Expand Down
3 changes: 1 addition & 2 deletions src/renderer/win32/composition_window.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
#include <windows.h>
#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlapp.h>
#include <atlcrack.h>
#include <atlgdi.h>
Expand Down
3 changes: 1 addition & 2 deletions src/renderer/win32/indicator_window.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
#include <windows.h>
#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlwin.h>
#include <atlapp.h>
#include <atlcrack.h>
Expand Down
3 changes: 1 addition & 2 deletions src/renderer/win32/infolist_window.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
#include <windows.h>
#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlwin.h>
#include <atlapp.h>
#include <atlcrack.h>
Expand Down
3 changes: 1 addition & 2 deletions src/renderer/win32/text_renderer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@

#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlcom.h>
#include <objbase.h>
#include <d2d1.h>
Expand Down
3 changes: 1 addition & 2 deletions src/renderer/win32/text_renderer.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
#include <windows.h>
#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlapp.h>
#include <atlmisc.h>

Expand Down
3 changes: 1 addition & 2 deletions src/renderer/win32/win32_image_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@

#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlapp.h>
#include <atlmisc.h>
#include <atlgdi.h>
Expand Down
3 changes: 1 addition & 2 deletions src/renderer/win32/win32_image_util_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@

#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlapp.h>
#include <atlgdi.h>
#include <atlmisc.h>
Expand Down
3 changes: 1 addition & 2 deletions src/renderer/win32/win32_renderer_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@

#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlapp.h>
#include <atlgdi.h>
#include <atlmisc.h>
Expand Down
3 changes: 1 addition & 2 deletions src/renderer/win32/win32_renderer_util_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@

#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlapp.h>
#include <atlgdi.h>
#include <atlmisc.h>
Expand Down
3 changes: 1 addition & 2 deletions src/server/mozc_cache_service.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
#define PSAPI_VERSION 1 // for <psapi.h>
#include <windows.h>
#if !defined(NO_LOGGING)
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlstr.h> // for CString
#endif // !NO_LOGGING
#include <psapi.h>
Expand Down
51 changes: 0 additions & 51 deletions src/win32/atl_wrapper/atlbase_mozc.h

This file was deleted.

3 changes: 1 addition & 2 deletions src/win32/base/accessible_object.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@

#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlcom.h>

#include <string>
Expand Down
3 changes: 1 addition & 2 deletions src/win32/base/accessible_object.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@

#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlcom.h>

#include <vector>
Expand Down
3 changes: 1 addition & 2 deletions src/win32/base/browser_info.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@

#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlcom.h>

#include <string>
Expand Down
3 changes: 1 addition & 2 deletions src/win32/base/focus_hierarchy_observer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@

#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlcom.h>

#include <memory>
Expand Down
3 changes: 1 addition & 2 deletions src/win32/base/imm_registrar.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@

#include <windows.h>
#include <WinNls32.h>
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <strsafe.h>

#include <iomanip>
Expand Down
3 changes: 1 addition & 2 deletions src/win32/base/imm_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@
#include "win32/base/imm_util.h"

#include <windows.h>
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlstr.h>
#include <imm.h>
#include <msctf.h>
Expand Down
3 changes: 1 addition & 2 deletions src/win32/base/migration_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@

#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlstr.h>

#include <strsafe.h>
Expand Down
3 changes: 1 addition & 2 deletions src/win32/base/omaha_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@
#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
#define _ATL_NO_HOSTING
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>

#include <string>

Expand Down
3 changes: 1 addition & 2 deletions src/win32/base/text_icon.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@

#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlapp.h>
#include <atlmisc.h>
#include <atlgdi.h>
Expand Down
3 changes: 1 addition & 2 deletions src/win32/base/text_icon_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@

#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlapp.h>
#include <atlmisc.h>
#include <atlgdi.h>
Expand Down
3 changes: 1 addition & 2 deletions src/win32/base/tsf_registrar.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
#include <windows.h>
#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <msctf.h>
#include <objbase.h>

Expand Down
3 changes: 1 addition & 2 deletions src/win32/base/uninstall_helper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@

#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlcom.h>
#include <msctf.h>
#include <strsafe.h>
Expand Down
3 changes: 1 addition & 2 deletions src/win32/base/win32_window_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
#define _ATL_NO_AUTOMATIC_NAMESPACE
#define _WTL_NO_AUTOMATIC_NAMESPACE
#define _ATL_NO_HOSTING
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlapp.h>
#include <atlwin.h>
#include <atlstr.h>
Expand Down
3 changes: 1 addition & 2 deletions src/win32/custom_action/custom_action.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@
#include "win32/custom_action/custom_action.h"

#include <windows.h>
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#if !defined(NO_LOGGING)
#include <atlstr.h>
#endif // !NO_LOGGING
Expand Down
3 changes: 1 addition & 2 deletions src/win32/ime/ime_input_context.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@
#include "win32/ime/ime_input_context.h"

#define _ATL_NO_HOSTING // prevents including <dimm.h>
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>
#include <atlwin.h>

#include "base/logging.h"
Expand Down
3 changes: 1 addition & 2 deletions src/win32/ime/ime_language_bar.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@
#include <rpcsal.h>
#include <msctf.h>
#include <ctffunc.h>
// Workaround against KB813540
#include <atlbase_mozc.h>
#include <atlbase.h>

#include "base/port.h"
#include "session/commands.pb.h"
Expand Down
Loading

0 comments on commit 091dc3b

Please sign in to comment.