Rename NonGeographicalRegion to NonGeographicalEntity. #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvislavski
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Can you also update https://github.com/google/libphonenumber/blob/master/pending_code_changes.txt with the explanation of this change? This will be included in the release notes then
java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java
Outdated
Show resolved
Hide resolved
KarolJakubKrawiec
force-pushed
the
rename-nongeographicalregion
branch
from
acb49f2 to
e49a7ac
Compare
tvislavski
previously approved these changes
Oct 2, 2024
KarolJakubKrawiec
force-pushed
the
rename-nongeographicalregion
branch
from
f916917 to
ae42ce6
Compare
This is to be consistent with the naming of non-geographical entities, since region and non-geographical can be contradictory.
Added ( - Renamed NonGeographicalRegion to NonGeographicalEntity. - Created a new interface called NonGeographicalEntityMetadataSourceV2) into the file.
Changed @deprecated use the following... to just @deprecated Use... to make every @deprecated comment the same.
I renamed the NonGeographicalRegion variables and methodes to NonGeographicalEntity because we want to keep the naming the same so its easier to read. This CL is for the C++ version.
KarolJakubKrawiec
force-pushed
the
rename-nongeographicalregion
branch
from
ae42ce6 to
32e0765
Compare
silvio2402
reviewed
Dec 11, 2024
Comment on lines
865
to
866
| const i18n::phonenumbers::PhoneMetadata* GetMetadataForNonGeographicalRegion( | ||
| int country_calling_code) const; |
There was a problem hiding this comment.
You can remove this since it is a private function.
Comment on lines
67
to
+70
| const PhoneMetadata* GetMetadataForNonGeographicalRegion( | ||
| int country_code) const { | ||
| return phone_util_.GetMetadataForNonGeographicalRegion(country_code); | ||
| return phone_util_.GetMetadataForNonGeographicalEntity(country_code); | ||
| } |
There was a problem hiding this comment.
You can also remove this because you already renamed the calls to this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to be consistent with the naming of non-geographical entities, since region and non-geographical can be contradictory.
Context: b/206752240