Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding anchors for all FAQ entries (down to ###) #1867

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Conversation

hagbard
Copy link
Contributor

@hagbard hagbard commented Jul 21, 2017

No description provided.

@hagbard hagbard requested a review from lararennie July 21, 2017 13:14
FAQ.md Outdated
@@ -311,7 +311,7 @@ IMPORTANT: Do not add a leading 1 or 9 for displaying or formatting the numbers.
Depending on the use case, other tokens may be needed. The library will do the
right thing if the phone number object is as intended.

### Why are Bouvet Island (BV), Pitcairn Island (PN), Antarctica (AQ) etc. not supported?
### <a name="#unsupported"/>Why are Bouvet Island (BV), Pitcairn Island (PN), Antarctica (AQ) etc. not supported?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#unsupported_region would be better I think.

@tvislavski tvislavski requested a review from penmetsaa July 11, 2022 09:18
@penmetsaa
Copy link
Contributor

Sorry for checking this late!
We will followup with a PR in case other new Questions also need hyperlinks

@penmetsaa penmetsaa merged commit 16a5d4d into master Jul 12, 2022
@tvislavski tvislavski mentioned this pull request Jul 12, 2022
@penmetsaa penmetsaa deleted the hagbard-patch-1 branch July 19, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants