Add FAQ for vanity numbers / parsing with non-digit characters #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lararennie
reviewed
Jul 4, 2017
FAQ.md
Outdated
| If the input looks like a vanity number to the library, `parse()` assumes this | ||
| is intentional and converts alpha characters to digits. Please read the | ||
| documentation for | ||
| [`parse()`](http://github.com/googlei18n/libphonenumber/blob/35210c7288b3953360289b24796330bc848dfe2d/java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java#L3040) |
There was a problem hiding this comment.
If we refer to master
(https://github.com/googlei18n/libphonenumber/blob/master/java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java)
then it'll always be up to date; on the other hand the line number will change...
I think probably best to have the "master" not the specific version, and tell people to search for parse?
lararennie
approved these changes
Jul 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cl/160892622
b/30128207
Please don't merge unless release is done.
This change is