Fix the baseline calculation above API Level 24+ #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thagikura
force-pushed
the
fix_baseline_341
branch
from
2107b90 to
a9b4885
Compare
Contributor
Author
|
This fixes #341 |
ghost
reviewed
Aug 8, 2017
|
|
||
| <TextView | ||
| android:id="@+id/text2" | ||
| android:layout_width="30dp" |
There was a problem hiding this comment.
As 30dp and 80dp are used three times here, I think that good idea would be to extract them to dimen variables.
Contributor
Author
There was a problem hiding this comment.
Thanks for your comment, but it's acceptable for me to have the three occurrences in the same file. Also I'd like to keep every XML file independent from each other rather than having common resources as a single test should not be affected by any other file changes.
yaraki
approved these changes
Aug 8, 2017
1 task
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the code to use View#getMeasuredHeight instead of View#getHeight where it should.