-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: errors from Client.Timeout triggering have .Timeout()==false #9405
Labels
Milestone
Comments
In which version of go this got fixed? |
Go 1.5 and above will contain the fix.
|
dropwhile
added a commit
to cactus/go-camo
that referenced
this issue
Aug 28, 2015
It seems[1] go http.Client errors changed a bit for go 1.5. [1]: golang/go#9405
stefanschneider
added a commit
to stefanschneider/rep
that referenced
this issue
Sep 22, 2015
Go 1.5 will return a different error message for http timeout. Ref: golang/go#9405
stefanschneider
added a commit
to stefanschneider/rep
that referenced
this issue
Sep 22, 2015
Go 1.5 will return a different error message for http timeout. Ref: golang/go#9405
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
(From aaronlevy on IRC)
It's hard for a client to know when a HTTP request failed due to timeout, and when for other reasons.
Given a slow server
and a client
Results in
That's quite the gift wrapping on that error. But the real bug is "is timeout: false". The error was caused by a timeout, it should claim to be one.
The text was updated successfully, but these errors were encountered: