feat: add support for OpenSSL 3.3.3 and 3.4.1, update version mappings#769
feat: add support for OpenSSL 3.3.3 and 3.4.1, update version mappings#769
Conversation
Signed-off-by: CFC4N <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for OpenSSL 3.3.3 and 3.4.1 by updating version constants, mapping logic in the probe module, and including new kernel header files for the new versions.
- Updates version constants and mapping loops in user/module/probe_openssl_lib.go.
- Adds new kernel files kern/openssl_3_3_3_kern.c and kern/openssl_3_4_1_kern.c.
- Adjusts script mappings for the new OpenSSL versions.
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| user/module/probe_openssl_lib.go | Updates constants and mapping loops to support OpenSSL 3.3.3/3.4.1. |
| kern/openssl_3_4_1_kern.c | New file containing kernel offsets for OpenSSL 3.4.1. |
| kern/openssl_3_3_3_kern.c | New file containing kernel offsets for OpenSSL 3.3.3. |
Files not reviewed (3)
- go.mod: Language not supported
- utils/openssl_offset_3.3.sh: Language not supported
- utils/openssl_offset_3.4.sh: Language not supported
Comments suppressed due to low confidence (1)
user/module/probe_openssl_lib.go:51
- [nitpick] The constant name 'SupportedOpenSSL33Version2' may be unclear when juxtaposed with 'MaxSupportedOpenSSL33Version'. Consider renaming these constants (e.g., to 'MinSupportedOpenSSL33VersionForMapping' and 'MaxSupportedOpenSSL33Version') to clearly indicate their intended use in version mapping.
SupportedOpenSSL33Version2 = 2 // openssl 3.3.2
|
Failed to generate code suggestions for PR |
|
Hi @cfc4n No, i am still facing same issue, i got a positive log like this Whenever i am sending curl https request but rquest/response aren't visible in pcapng file, i am attaching a sample pcapng file here I ran ecapture like this And in wireshark i can see plaintext response of |
It looks like you may have misconfigured the network interface? PS: I will merge the content of PR #770 here, but I will give you a co-author. Please provide your email address. |
|
Hi @cfc4n, If the network interface was misconfigured, I believe ecapture wouldn’t have shown any logs or HTTPS SNIs at all, right? Also, I noticed that curl HTTP requests are getting captured — only the plaintext of HTTPS requests isn’t showing up. Also, just curious — why do you need the email address for this PR contribution? I thought the GitHub profile would be sufficient. |
|
I couldn't find the key Also, please ensure that eCaptured is started before the HTTPS connection is established. About |
Signed-off-by: CFC4N <[email protected]>
…n mappings fix: #771 Signed-off-by: CFC4N <[email protected]>
This pull request includes updates to dependencies, support for new OpenSSL versions, and adjustments to related logic and scripts. The most significant changes involve upgrading Go module dependencies, adding support for OpenSSL versions 3.3.3 and 3.4.1, and updating scripts to reflect these new versions.
Dependency Updates:
go.mod, includinggolang.org/x/arch,golang.org/x/crypto,golang.org/x/net,golang.org/x/sys, and others to their latest versions. [1] [2] [3]OpenSSL Version Support:
kern/openssl_3_3_3_kern.candkern/openssl_3_4_1_kern.cwith constants and offsets for OpenSSL 3.3.3 and 3.4.1, respectively. [1] [2]user/module/probe_openssl_lib.goto include logic for handling OpenSSL 3.3.3 and 3.4.1 in theinitOpensslOffsetfunction. [1] [2] [3]Script Adjustments:
utils/openssl_offset_3.3.shandutils/openssl_offset_3.4.shscripts to include mappings for OpenSSL 3.3.3 and 3.4.1. [1] [2]BugFix
fix: #767