[HIGH PRIORITY] Fixed Xorm V6 compile errors #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@unknwon please 🚢 |
|
Could you update the glide & gopm-files to reflect the changed version as well |
|
I think maybe you have made a mistake. |
unknwon
added
status: needs feedback
|
Thanks! |
|
@lunny I read somewhere that it might not be supported always. Still, might be useful to upgrade it to go-xorm/builder. |
richmahn
referenced
this pull request
in unfoldingWord/dcs
Sep 25, 2016
1 task
ghost
deleted the
richmahn
referenced
this pull request
in unfoldingWord/dcs
Nov 18, 2016
richmahn
pushed a commit
to richmahn/gogs
that referenced
this pull request
Nov 23, 2016
jvanderneutstulen
added a commit
to jvanderneutstulen/gogs
that referenced
this pull request
Dec 13, 2016
This reverts commit 2bec8a4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT CLOSE THIS. THIS FIXES XORM COMPILE ERRORS.
Description
The newest version of xorm changes the xorm.Engine interface where the Where, is no longer
Where(string, ...interface{}) *xorm.Sessionbut insteadWhere(interface{}, ...interface{}) *xorm.Session. However, xorm still supports string queries.I've read somewhere that the string query may be deprecated and removed soon, so this fix may or may not be a permanent solution, thus it is best to slowly convert existing database queries to use go-xorm/builder.