Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix review request API #32642

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fix review request API #32642

wants to merge 11 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 25, 2024 •
edited
Loading

This PR introduces restrictions on who can be selected for review requests via the API.
It also moves all review requests logic to pull request services rather than issue services package.

Fix #32637
Fix https://github.com/go-gitea/gitea/pull/32403/files#r1852829227

@lunny lunny added the type/bug label Nov 25, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 25, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 25, 2024
@lunny lunny force-pushed the lunny/fix_reviewrequest_API branch from 55c2397 to 94d8868 Compare November 26, 2024 04:41
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 26, 2024
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
@lunny lunny force-pushed the lunny/fix_reviewrequest_API branch from 0358a67 to 27983ef Compare December 7, 2024 05:26
@lunny lunny force-pushed the lunny/fix_reviewrequest_API branch from 27983ef to 7c6cd3e Compare January 24, 2025 22:38
@lunny lunny added this to the 1.24.0 milestone Jan 24, 2025
@lunny lunny force-pushed the lunny/fix_reviewrequest_API branch from fce09e1 to 9d6588e Compare January 26, 2025 02:57
@lunny lunny marked this pull request as ready for review January 26, 2025 03:33
@lunny
Copy link
Member Author

lunny commented Jan 26, 2025

This is ready to review now.

@lunny lunny mentioned this pull request Jan 26, 2025
Open
@lunny lunny added the backport/v1.23 This PR should be backported to Gitea 1.23 label Jan 26, 2025
@lunny lunny mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Ramdom users can be added as reviewers via API, while not via UI
2 participants
@lunny @GiteaBot