Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor markup render system #32589

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Refactor markup render system #32589

merged 4 commits into from
Nov 22, 2024

Conversation

wxiaoguang
Copy link
Contributor

This PR mainly moves some code and introduces RenderContext.WithXxx functions

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 21, 2024
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 21, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 21, 2024
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 21, 2024
@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Nov 21, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 21, 2024
@wxiaoguang wxiaoguang requested a review from a team November 22, 2024 02:02
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 22, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) November 22, 2024 02:11
@wxiaoguang wxiaoguang merged commit c4e27cb into go-gitea:main Nov 22, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the refacor-markup branch November 22, 2024 05:54
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 22, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5fdcb5d 
* giteaofficial/main:
  Fix get reviewers' bug (go-gitea#32415)
  Fix issues with inconsistent spacing in areas (go-gitea#32607)
  Refactor markup render system (go-gitea#32589)
  Style unification for the issue_management area (go-gitea#32605)
  Enhancing Gitea OAuth2 Provider with Granular Scopes for Resource Access (go-gitea#32573)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerwin612 kerwin612 kerwin612 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @kerwin612 @GiteaBot