Optimize installation-page experience #32558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
the
modifies/templates
lunny
approved these changes
Nov 19, 2024
GiteaBot
added
lgtm/need 1
a1012112796
reviewed
Nov 19, 2024
delvh
approved these changes
Nov 19, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 20, 2024
* giteaofficial/main: Remove duplicate empty repo check in delete branch API (go-gitea#32569) Optimize installation-page experience (go-gitea#32558) Remove unnecessary code (go-gitea#32560) Fix a compilation error in the Gitpod environment (go-gitea#32559) Use user.FullName in Oauth2 id_token response (go-gitea#32542) Fix some places which doesn't repsect org full name setting (go-gitea#32243) Refactor push mirror find and add check for updating push mirror (go-gitea#32539) Refactor markup render system (go-gitea#32533) Refactor find forks and fix possible bugs that weak permissions check (go-gitea#32528) Use better name for userinfo structure (go-gitea#32544)
wxiaoguang
reviewed
Nov 20, 2024
| @@ -352,6 +352,7 @@ enable_update_checker = Enable Update Checker | |||
| enable_update_checker_helper = Checks for new version releases periodically by connecting to gitea.io. | |||
| env_config_keys = Environment Configuration | |||
| env_config_keys_prompt = The following environment variables will also be applied to your configuration file: | |||
| config_write_file_prompt = These configuration options will be written into: | |||
There was a problem hiding this comment.
To make it translatable ,it should be These .. into: %s
There was a problem hiding this comment.
Lines 341 to 342 in cd598bf
I'm not sure if I understand correctly; The file path has already been changed into an element node, so it's not suitable to be passed as a placeholder to config_write_file_prompt, right?
There was a problem hiding this comment.
{{$html := HTMLFormat `<label>%s</label>` .CustomConfFile}}
{{ctx.Locale.Tr `tip` $html}}
There was a problem hiding this comment.
I understand the necessity of doing it this way now. I'll make the changes right away. Thank you for your reminder.
There was a problem hiding this comment.
If you were doing i18n, then it needs to make it translatable for all languages, many languages do not use "A: b" syntax.
Otherwise, keep it in English if it doesn't matter (that's why I didn't translate it)
kerwin612
added a commit
to kerwin612/gitea
that referenced
this pull request
Nov 21, 2024
lunny
pushed a commit
that referenced
this pull request
Nov 21, 2024
Thank you for @wxiaoguang's reminders and suggestions: #32558 (comment)
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 22, 2024
* giteaofficial/main: Add line-through for deleted branch on pull request view page (go-gitea#32500) Fix issue sidebar regression (go-gitea#32598) Fix PR diff review form submit (go-gitea#32596) Fix some typescript issues (go-gitea#32586) Fix GetInactiveUsers (go-gitea#32540) disable gravatar in test (go-gitea#32529) Add 'Copy path' button to file view (go-gitea#32584) Improve issue sidebar UI (go-gitea#32587) Supplement and Improvement for go-gitea#32558 (go-gitea#32585) make search box in issue sidebar dropdown list always show when scrolling (go-gitea#32576) Fix submodule parsing (go-gitea#32571) allow the actions user to login via the jwt token (go-gitea#32527) Support HTTP POST requests to `/userinfo`, aligning to OpenID Core specification (go-gitea#32578)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlight the path of the configuration file with a label-style emphasis and provide a quick copy button.