Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automerge supports deleting branch automatically after merging #32343

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Automerge supports deleting branch automatically after merging #32343

wants to merge 16 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 26, 2024 •
edited
Loading

Resolve #32341
Depends on #27151

  • It will display the checkbox of deleting head branch on the pull request view page when starting an auto-merge task.
  • Add permission check before deleting the branch
  • Add delete branch comment for those closing pull requests because of head branch or base branch was deleted.

@lunny lunny added the type/enhancement An improvement of existing functionality label Oct 26, 2024
@lunny lunny added this to the 1.23.0 milestone Oct 26, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 26, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 26, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/migrations modifies/frontend labels Oct 26, 2024
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 10, 2024
lunny
lunny commented Nov 10, 2024
View reviewed changes
routers/api/v1/repo/branch.go Outdated Show resolved Hide resolved
@lunny lunny marked this pull request as draft November 10, 2024 02:18
@lunny lunny mentioned this pull request Nov 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp05327 yp05327 yp05327 left review comments

@wxiaoguang wxiaoguang wxiaoguang left review comments

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/frontend modifies/go Pull requests that update Go code modifies/migrations size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Automerge doesn't respect branch deletion rule
4 participants
@lunny @wxiaoguang @yp05327 @GiteaBot