Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move delete deploy keys into service layer #32201

Merged
merged 14 commits into from
Dec 18, 2024
Merged

Move delete deploy keys into service layer #32201

merged 14 commits into from
Dec 18, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 5, 2024

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 5, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 5, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 5, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 5, 2024
@lunny lunny requested review from delvh and Zettat123 December 4, 2024 06:07
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Dec 5, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 6, 2024
delvh
delvh reviewed Dec 6, 2024
View reviewed changes
models/repo.go Show resolved Hide resolved
@lunny
Copy link
Member Author

lunny commented Dec 17, 2024

Last call for another review @go-gitea/technical-oversight-committee

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 17, 2024
@lunny lunny added this to the 1.24.0 milestone Dec 18, 2024
@lunny lunny enabled auto-merge (squash) December 18, 2024 03:58
@lunny lunny merged commit f9f62b4 into go-gitea:main Dec 18, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 18, 2024
@lunny lunny deleted the lunny/move-delete-deploy-key branch December 18, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @Zettat123 @delvh @GiteaBot