Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desugar use expression #3824

Merged
merged 9 commits into from
Nov 21, 2024
Merged

Desugar use expression #3824

merged 9 commits into from
Nov 21, 2024

Conversation

giacomocavalieri
Copy link
Member

@giacomocavalieri giacomocavalieri commented Nov 12, 2024 •
edited
Loading

This PR closes #3314

Since this is a new feature, I'm making the PR a WIP until 1.6 is released so I can write the changelog later and not deal with conflicts

@GearsDatapacks GearsDatapacks mentioned this pull request Nov 18, 2024
Closed
@giacomocavalieri giacomocavalieri marked this pull request as ready for review November 18, 2024 22:28
lpil
lpil reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have some tests for when the arguments have annotations please 🙏

@lpil lpil marked this pull request as draft November 19, 2024 14:19
@giacomocavalieri
Copy link
Member Author

Could we have some tests for when the arguments have annotations please 🙏

I've added one!

@giacomocavalieri giacomocavalieri marked this pull request as ready for review November 19, 2024 16:02
@giacomocavalieri giacomocavalieri mentioned this pull request Nov 19, 2024
Merged
@giacomocavalieri
Copy link
Member Author

This is ready for review now!

lpil
lpil approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous! Thank you!!!

@lpil lpil merged commit 3d62ab4 into gleam-lang:main Nov 21, 2024
12 checks passed
@giacomocavalieri giacomocavalieri deleted the fix-3314 branch November 21, 2024 11:37
@inoas
Copy link
Contributor

inoas commented Nov 21, 2024

Thank you, this will help tons while explaining gleam use to newbies :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LSP Code Action: Desugar use expression
3 participants
@giacomocavalieri @inoas @lpil