Directly handle rate limiting using client.rate_limit.resets_in.
#967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Ugh I was so curious about the test results, and it was styling issues that stopped the build. I should flip those around, check style after running tests. |
olleolleolle
reviewed
Jun 3, 2021
| rescue MovedPermanentlyError => e | ||
| fail_with_message(e, "The repository has moved, update your configuration") | ||
| rescue Octokit::TooManyRequests => e | ||
| resets_in = client.rate_limit.resets_in |
Collaborator
There was a problem hiding this comment.
🔍 I learned! resets_in (a time) is even provided by Octokit, thanks for finding this out!
Contributor
Author
There was a problem hiding this comment.
You are most welcome!
olleolleolle
approved these changes
Jun 3, 2021
Collaborator
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
👍 This lets us use Octokit in a more precise way.
Contributor
Author
|
Thanks for handling this! |
|
it seems that It does not work well as before. |
Contributor
Author
|
@aelam what is the problem? |
|
@ioquatix Sorry for late, after I waited a long time, it worked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed some issues here, and at least when I tried, it, I ran into rate limiting issues.
#965 (comment)
This PR tries to respect GitHub's rate limiting.