Fix not parsing body_only param for sections #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Contributor
|
Hi @dusan-dragon, thanks for this PR :) Can you please add a test case, so we can verify this does not break in the future? Thanks! |
Author
|
Hi @ferrarimarco added test, also checked that it is failing on master. |
Author
|
@ferrarimarco ping |
Contributor
|
Hi! Will have a look ASAP, thanks for your patience |
Author
|
ping, any updates on this? |
Author
|
@ferrarimarco ping |
Contributor
|
@olleolleolle can you have a look at this? You know the code base better :) Thanks! |
olleolleolle
approved these changes
Apr 10, 2020
Collaborator
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
Looks reasonable, thanks for explaining how the failure occurred. LGTM!
Collaborator
|
Thanks, @dusan-dragon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
body_onlyis not filled into sections properly. This is an issue because if you will useconfigure-sectionsyou will loss "Release summary" section. Because there is no way how to enable body_only param.