Lowercase headers #533
Merged
Lowercase headers #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this! It'd be great to have this merged and released to unblock local development with Rack 3.x. |
rzhade3
requested changes
Dec 6, 2024
Contributor
rzhade3
left a comment
rzhade3
left a comment
There was a problem hiding this comment.
Thanks for this PR! This is a great change. Couple changes suggested below after which we can merge this PR in:
Contributor
Author
|
thanks! @rzhade3 |
KyFaSt
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All PRs:
Adding a new header
Generally, adding a new header is always OK.
Adding a new CSP directive
Rack 3
Response header keys can no longer include uppercase characters.https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md#rack-3-upgrade-guide
Rack Lint error out when using
secure_headersbecause its adding headers with uppercase